Support Chunking in StreamData #248
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D81824143 |
macvincent
force-pushed
the
export-D81824143
branch
from
8927140 to
8af4c2e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81824143 |
macvincent
force-pushed
the
export-D81824143
branch
from
8af4c2e to
da6ccfd
Compare
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Sep 11, 2025
Summary: Another feature in the new chunking policy described in this [doc](https://fburl.com/gdoc/gkdwwju1) is the ability to split large streams above a specified limit into smaller chunks. In this diff, we implement a `popChunk` method in each `StreamData` class to handle this functionality. With this feature we are not forced to encode extremely large streams into a single chunk. Integration will happen in the next diff. Differential Revision: D81824143
|
This pull request was exported from Phabricator. Differential Revision: D81824143 |
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Sep 11, 2025
Summary: Another feature in the new chunking policy described in this [doc](https://fburl.com/gdoc/gkdwwju1) is the ability to split large streams above a specified limit into smaller chunks. In this diff, we implement a `popChunk` method in each `StreamData` class to handle this functionality. With this feature we are not forced to encode extremely large streams into a single chunk. Integration will happen in the next diff. Differential Revision: D81824143
macvincent
force-pushed
the
export-D81824143
branch
from
da6ccfd to
9e3a7a1
Compare
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Sep 12, 2025
Summary: Another feature in the new chunking policy described in this [doc](https://fburl.com/gdoc/gkdwwju1) is the ability to split large streams above a specified limit into smaller chunks. In this diff, we implement a `popChunk` method in each `StreamData` class to handle this functionality. With this feature we are not forced to encode extremely large streams into a single chunk. Integration will happen in the next diff. Differential Revision: D81824143
|
@macvincent has exported this pull request. If you are a Meta employee, you can view the originating diff in D81824143. |
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Sep 12, 2025
Summary: Another feature in the new chunking policy described in this [doc](https://fburl.com/gdoc/gkdwwju1) is the ability to split large streams above a specified limit into smaller chunks. In this diff, we implement a `popChunk` method in each `StreamData` class to handle this functionality. With this feature we are not forced to encode extremely large streams into a single chunk. Integration will happen in the next diff. Differential Revision: D81824143
macvincent
force-pushed
the
export-D81824143
branch
from
9e3a7a1 to
efae00b
Compare
|
@macvincent has exported this pull request. If you are a Meta employee, you can view the originating diff in D81824143. |
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Sep 12, 2025
Summary: Another feature in the new chunking policy described in this [doc](https://fburl.com/gdoc/gkdwwju1) is the ability to split large streams above a specified limit into smaller chunks. In this diff, we implement a `popChunk` method in each `StreamData` class to handle this functionality. With this feature we are not forced to encode extremely large streams into a single chunk. Integration will happen in the next diff. Differential Revision: D81824143
macvincent
force-pushed
the
export-D81824143
branch
from
efae00b to
7e5093c
Compare
|
@macvincent has exported this pull request. If you are a Meta employee, you can view the originating diff in D81824143. |
macvincent
force-pushed
the
export-D81824143
branch
from
7e5093c to
ef1b6e9
Compare
|
@macvincent has exported this pull request. If you are a Meta employee, you can view the originating diff in D81824143. |
macvincent
force-pushed
the
export-D81824143
branch
from
ef1b6e9 to
9898293
Compare
|
@macvincent has exported this pull request. If you are a Meta employee, you can view the originating diff in D81824143. |
macvincent
force-pushed
the
export-D81824143
branch
from
9898293 to
87b6dc7
Compare
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Sep 29, 2025
Summary: Another feature in the new chunking policy described in this [doc](https://fburl.com/gdoc/gkdwwju1) is the ability to split large streams above a specified limit into smaller chunks. In this diff, we implement a `popChunk` method in each `StreamData` class to handle this functionality. With this feature we are not forced to encode extremely large streams into a single chunk. Integration will happen in the next diff. Differential Revision: D81824143
|
@macvincent has exported this pull request. If you are a Meta employee, you can view the originating diff in D81824143. |
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Sep 29, 2025
Summary: Another feature in the new chunking policy described in this [doc](https://fburl.com/gdoc/gkdwwju1) is the ability to split large streams above a specified limit into smaller chunks. In this diff, we implement a `popChunk` method in each `StreamData` class to handle this functionality. With this feature we are not forced to encode extremely large streams into a single chunk. Integration will happen in the next diff. Differential Revision: D81824143
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Sep 30, 2025
Summary: Another feature in the new chunking policy described in this [doc](https://fburl.com/gdoc/gkdwwju1) is the ability to split large streams above a specified limit into smaller chunks. In this diff, we implement a `popChunk` method in each `StreamData` class to handle this functionality. With this feature we are not forced to encode extremely large streams into a single chunk. Integration will happen in the next diff. Differential Revision: D81824143
macvincent
force-pushed
the
export-D81824143
branch
from
87b6dc7 to
91e94f6
Compare
|
@macvincent has exported this pull request. If you are a Meta employee, you can view the originating diff in D81824143. |
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Oct 29, 2025
Summary: Another feature in the new chunking policy described in this [doc](https://fburl.com/gdoc/gkdwwju1) is the ability to split large streams above a specified limit into smaller chunks. In this diff, we implement a `popChunk` method in each `StreamData` class to handle this functionality. With this feature we are not forced to encode extremely large streams into a single chunk. Integration will happen in the next diff. Reviewed By: helfman Differential Revision: D81824143
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Oct 29, 2025
Summary: Another feature in the new chunking policy described in this [doc](https://fburl.com/gdoc/gkdwwju1) is the ability to split large streams above a specified limit into smaller chunks. In this diff, we implement a `popChunk` method in each `StreamData` class to handle this functionality. With this feature we are not forced to encode extremely large streams into a single chunk. Integration will happen in the next diff. Reviewed By: helfman Differential Revision: D81824143
macvincent
force-pushed
the
export-D81824143
branch
2 times, most recently
from
10afea6 to
5a5792b
Compare
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Oct 29, 2025
Summary: Another feature in the new chunking policy described in this [doc](https://fburl.com/gdoc/gkdwwju1) is the ability to split large streams above a specified limit into smaller chunks. In this diff, we implement a `popChunk` method in each `StreamData` class to handle this functionality. With this feature we are not forced to encode extremely large streams into a single chunk. Integration will happen in the next diff. Reviewed By: helfman Differential Revision: D81824143
macvincent
force-pushed
the
export-D81824143
branch
from
5a5792b to
202fa1b
Compare
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Oct 29, 2025
Summary: Another feature in the new chunking policy described in this [doc](https://fburl.com/gdoc/gkdwwju1) is the ability to split large streams above a specified limit into smaller chunks. In this diff, we implement a `popChunk` method in each `StreamData` class to handle this functionality. With this feature we are not forced to encode extremely large streams into a single chunk. Integration will happen in the next diff. Reviewed By: helfman Differential Revision: D81824143
macvincent
force-pushed
the
export-D81824143
branch
from
202fa1b to
3e4661d
Compare
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Oct 29, 2025
Summary: Another feature in the new chunking policy described in this [doc](https://fburl.com/gdoc/gkdwwju1) is the ability to split large streams above a specified limit into smaller chunks. In this diff, we implement a `popChunk` method in each `StreamData` class to handle this functionality. With this feature we are not forced to encode extremely large streams into a single chunk. Integration will happen in the next diff. Reviewed By: helfman Differential Revision: D81824143
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Oct 30, 2025
Summary: Another feature in the new chunking policy described in this [doc](https://fburl.com/gdoc/gkdwwju1) is the ability to split large streams above a specified limit into smaller chunks. In this diff, we implement a `popChunk` method in each `StreamData` class to handle this functionality. With this feature we are not forced to encode extremely large streams into a single chunk. Integration will happen in the next diff. Reviewed By: helfman Differential Revision: D81824143
macvincent
force-pushed
the
export-D81824143
branch
from
3e4661d to
f5a9f56
Compare
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Oct 30, 2025
Summary: Pull Request resolved: facebookincubator#248 Another feature in the new chunking policy described in this [doc](https://fburl.com/gdoc/gkdwwju1) is the ability to split large streams above a specified limit into smaller chunks. In this diff, we implement a `popChunk` method in each `StreamData` class to handle this functionality. With this feature we are not forced to encode extremely large streams into a single chunk. Integration will happen in the next diff. Differential Revision: D81824143 Reviewed By: helfman
macvincent
force-pushed
the
export-D81824143
branch
from
f5a9f56 to
d5d4df2
Compare
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Oct 31, 2025
Summary: Another feature in the new chunking policy described in this [doc](https://fburl.com/gdoc/gkdwwju1) is the ability to split large streams above a specified limit into smaller chunks. In this diff, we implement a `popChunk` method in each `StreamData` class to handle this functionality. With this feature we are not forced to encode extremely large streams into a single chunk. Integration will happen in the next diff. Reviewed By: helfman Differential Revision: D81824143
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Oct 31, 2025
Summary: Pull Request resolved: facebookincubator#248 Another feature in the new chunking policy described in this [doc](https://fburl.com/gdoc/gkdwwju1) is the ability to split large streams above a specified limit into smaller chunks. In this diff, we implement a `popChunk` method in each `StreamData` class to handle this functionality. With this feature we are not forced to encode extremely large streams into a single chunk. Integration will happen in the next diff. Differential Revision: D81824143 Reviewed By: helfman
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Nov 3, 2025
Summary: Another feature in the new chunking policy described in this [doc](https://fburl.com/gdoc/gkdwwju1) is the ability to split large streams above a specified limit into smaller chunks. In this diff, we implement a `popChunk` method in each `StreamData` class to handle this functionality. With this feature we are not forced to encode extremely large streams into a single chunk. Integration will happen in the next diff. Reviewed By: helfman Differential Revision: D81824143
macvincent
force-pushed
the
export-D81824143
branch
from
d5d4df2 to
4a236cb
Compare
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Nov 3, 2025
Summary: Pull Request resolved: facebookincubator#248 Another feature in the new chunking policy described in this [doc](https://fburl.com/gdoc/gkdwwju1) is the ability to split large streams above a specified limit into smaller chunks. In this diff, we implement a `popChunk` method in each `StreamData` class to handle this functionality. With this feature we are not forced to encode extremely large streams into a single chunk. Integration will happen in the next diff. Differential Revision: D81824143 Reviewed By: helfman
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Nov 4, 2025
Summary: Another feature in the new chunking policy described in this [doc](https://fburl.com/gdoc/gkdwwju1) is the ability to split large streams above a specified limit into smaller chunks. In this diff, we implement a `popChunk` method in each `StreamData` class to handle this functionality. With this feature we are not forced to encode extremely large streams into a single chunk. Integration will happen in the next diff. Reviewed By: helfman Differential Revision: D81824143
macvincent
force-pushed
the
export-D81824143
branch
2 times, most recently
from
f0a5699 to
c8d641d
Compare
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Nov 4, 2025
Summary: Another feature in the new chunking policy described in this [doc](https://fburl.com/gdoc/gkdwwju1) is the ability to split large streams above a specified limit into smaller chunks. In this diff, we implement a `popChunk` method in each `StreamData` class to handle this functionality. With this feature we are not forced to encode extremely large streams into a single chunk. Integration will happen in the next diff. Reviewed By: helfman Differential Revision: D81824143
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Nov 4, 2025
Summary: Another feature in the new chunking policy described in this [doc](https://fburl.com/gdoc/gkdwwju1) is the ability to split large streams above a specified limit into smaller chunks. In this diff, we implement a `popChunk` method in each `StreamData` class to handle this functionality. With this feature we are not forced to encode extremely large streams into a single chunk. Integration will happen in the next diff. Reviewed By: helfman Differential Revision: D81824143
…ator#243) Summary: This is an implementation of a detail in the new chunking policy described in this [doc](https://fburl.com/gdoc/gkdwwju1). Rather than chunking all eligible streams, we chunk individual streams in the order of their raw size until memory pressure is relieved. For our unit tests, the maximum number of chunks produced is identical to the previous implementation. But there may be differences for large file sizes. This requires more experimentation and tuning to determine the right threshold value that takes advantage of this. Reviewed By: helfman Differential Revision: D81715655
Summary: Another feature in the new chunking policy described in this [doc](https://fburl.com/gdoc/gkdwwju1) is the ability to split large streams above a specified limit into smaller chunks. In this diff, we implement a `popChunk` method in each `StreamData` class to handle this functionality. With this feature we are not forced to encode extremely large streams into a single chunk. Integration will happen in the next diff. Reviewed By: helfman Differential Revision: D81824143
macvincent
force-pushed
the
export-D81824143
branch
from
c8d641d to
d75869f
Compare
|
This pull request has been merged in 91bd161. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Another feature in the new chunking policy described in this doc is the ability to split large streams above a specified limit into smaller chunks. In this diff, we implement a
popChunkmethod in eachStreamDataclass to handle this functionality. With this feature we are not forced to encode extremely large streams into a single chunk.Integration will happen in the next diff.
Differential Revision: D81824143